Treat generated column number as 0-based in indexed originalPositionFor #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
originalPositionForbehaves differently inBasicSourceMapConsumerandIndexedSourceMapConsumer:columnargument is (correctly and as documented) treated as 0-based.columnargument is treated as 1-based for the purpose of locating the section in which the generated position occurs (as the internalsection.generatedOffset.generatedColumnfield is, for whatever reason, 1-based).This is a longstanding issue, going back to the introduction of
IndexedSourceMapConsumerAFAICT, but the behavior is incorrect. This PR fixes the issue and adds a corresponding test.